[Bug 835170] Review Request: cgdcbxd - dcb network priority manager

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=835170

--- Comment #7 from Neil Horman <nhorman@xxxxxxxxxx> ---
Spec URL: http://people.redhat.com/nhorman/cgdcbxd.spec
SRPM URL: http://people.redhat.com/nhorman/cgdcbxd-1.0.1-1.fc16.src.rpm

New spec and rpm for you.  Issues addressed:
[!]: MUST Buildroot is not present
     Removed from spec

[!]: MUST Package consistently uses macro is (instead of hard-coded directory
     names).
     Changed to consistently use RPM_BUILD_ROOT


[!]: SHOULD SourceX tarball generation or download is documented.
     Documented both upstream tarball and unit file sources

[!]: MUST Package does not own files or directories owned by other packages.
     Unit file renamed.  sorry about that, I was using the irqbalance unit file 
     as a guide and must have just entered the name wrong.

[!]: MUST Requires correct, justified where necessary.
     Updated to reflect https://fedoraproject.org/wiki/Packaging:Systemd

[!]: MUST Package does not generate any conflict.
     Should be clean now.

[!]: MUST Package consistently uses macro is (instead of hard-coded directory
     names )
     Fixed to consistently use %{_unitdir}

[!]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
     Done

[!]: MUST Buildroot is not present
     Note: Buildroot is not needed unless packager plans to package for EPEL5
     Removed from spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review