[Bug 838971] Review request: znc-colloquypush - ZNC module that pushes priv messages and hilights to Colloquy Mobile

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=838971

--- Comment #1 from Marek Mahut <mmahut@xxxxxxxxxx> ---
+ named is correct
+ latest source code is being shipped
+ spec file is clean
+ license is correct and OSS

- BuildRequires is checked only after all headers has been evaluted, for this
reason you cannot use znc-config in your Requires
- rm -rf $RPM_BUILD_ROOT in %install is recommended
- typo in tarball comments, s/guy/quy/
- docs are missing, please include README and maybe even AUTHORS
- please specify the full patch of the plugin instead owning the libdir/znc,
which
  can be used by different plugins

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review