[Bug 831491] Review Request: php-zmq - PHP 0MQ/zmq/zeromq extension

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=831491

Jon Ciesla <limburgher@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Jon Ciesla <limburgher@xxxxxxxxx> ---
- rpmlint checks return:

See above.  All ok except for the private-shared-object-provides.

- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
FIX no unnecessary BR  No need to BR gcc
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Otherwise it looks good, just the spurious gcc BR and the provides.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review