[Bug 830277] wmcoincoin-2.5.1f1.fc17 Funny dock-app for browsing and interact to XML board sites

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=830277

--- Comment #5 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> ---
Just some comments for the moment:

- you MUST NOT fix yourself the FSF address in the source code and the license.
It's up to you to warn the wmcoincoin's developers about this issue.

- you don't need to provide the INSTALL file, it's useless since users don't
care about the way to install manually wmcoincoin.

- you should use a loop to fix encoding, it will make your spec more legible:
for f in AUTHORS COPYING README NEWS TODO; do
   iconv -f iso8859-1 -t utf-8 $f >$f.conv && mv -f $f.conv $f
done

- in %setup section:
    %setup -q -n %{name}-%{version}
  You can simply replace this line by:
    %setup -q
  The %setup macro uses the %{name}-%{version} pattern by default.

- The %clean section is useless, as well as cleaning the buildroot in %prep:
    https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
   Please remove them.

- %defattr is useless too:
    https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

- Be careful with the version: 2.5.1f seems to be a 2.5.1 post-release. Please
refer to
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages
to fix it.

- These macro definitions are useless:
    %define name wmcoincoin
    %define version 2.5.1f
    %define release 1%{?dist}
   You MUST remove them.

- Don't forget to add a final dot in English and French descriptions. Sentences
always end with a dot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review