[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=821845

Peter Lemenkov <lemenkov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #6 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to comment #5)
> full review below. Some notes:
> 
> - could you make the build more verbose (by passing REBAR_FLAGS="-v" ?)
> - the comment regarding the Open Data license needs to be updated --
> probably remove the AFAIK and IANAL part since spot and the legal team has
> reviewed it
> - defattr needs removing

All done, and thanks for the review!

Updated packages:

* http://peter.fedorapeople.org/erlang-egeoip.spec
*
http://peter.fedorapeople.org/erlang-egeoip-0-0.3.20111025git45c32ad.fc18.src.rpm

Koji scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=4135307



New Package SCM Request
=======================
Package Name: erlang-egeoip
Short Description: Erlang IP Geolocation module
Owners: peter
Branches: f16 f17 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]