[Bug 827649] Review Request: supercat - colorized cat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=827649

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@xxxxxxxxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mail@xxxxxxxxxxxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
Just some quick comments:

- You are mixing variable style ($RPM_BUILD_ROOT) and macro style
(%{buildroot}).
- There is a typo in the summary. 
- Using macros in Source0 would make your life easier when updating the package
later.
- The %clean section is no longer needed. The build root is clean in the
%install section automatically too.
  https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
- In the description at the end a period is missing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]