[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 821511] Review Request: hornetq - High performance messaging system



https://bugzilla.redhat.com/show_bug.cgi?id=821511

--- Comment #10 from Mary Ellen Foster <mefoster@xxxxxxxxx> ---
Issues:
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: These BR are not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
==> Do you really need Requires: libaoi-devel on the -devel package?

[!]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0: hornetq-%{version}-CLEAN.tar.xz
     (hornetq-%{version}-CLEAN.tar.xz) Patch0: 0001-Removed-maven-buildmagic-
     thirdparty-plugin-dependenc.patch (0001-Removed-maven-buildmagic-
     thirdparty-plugin-dependenc.patch) Patch1: 0002-Removed-spring-
     dependency.patch (0002-Removed-spring-dependency.patch) Patch2: 0003-gui-
     aid-changes.patch (0003-gui-aid-changes.patch) Patch3: 0004-JDK7-fix-for-
     FileChannel-constructor.patch (0004-JDK7-fix-for-FileChannel-
     constructor.patch) Patch4: 0005-Libraries-paths.patch (0005-Libraries-
     paths.patch) Patch5: 0006-Make-creation-of-pom-files-easier.patch (0006
     -Make-creation-of-pom-files-easier.patch) Patch6: 0007-Add-jdepend-
     dependency-to-run-javadoc-creation.patch (0007-Add-jdepend-dependency-to-
     run-javadoc-creation.patch) Patch7: 0008-Native-build-fixes.patch (0008
     -Native-build-fixes.patch)
==> Add %{name} to the filename of Source0 and all of the patches

[!]: MUST Rpmlint output is silent.
==> Okay
rpmlint hornetq-devel-2.2.13-3.fc18.i686.rpm

hornetq-devel.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error
403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint hornetq-2.2.13-3.fc18.i686.rpm

hornetq.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
hornetq.i686: W: spelling-error %description -l en_US embeddable -> embedded
hornetq.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error 403:
Forbidden
hornetq.i686: W: no-manual-page-for-binary hornetq-disktest
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint hornetq-2.2.13-3.fc18.src.rpm

hornetq.src: W: spelling-error %description -l en_US multi -> mulch, mufti
hornetq.src: W: spelling-error %description -l en_US embeddable -> embedded
hornetq.src: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error 403:
Forbidden
hornetq.src: W: invalid-url Source0: hornetq-2.2.13-CLEAN.tar.xz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint hornetq-javadoc-2.2.13-3.fc18.i686.rpm

hornetq-javadoc.i686: W: spelling-error Summary(en_US) Javadocs -> Java docs,
Java-docs, Avocados
hornetq-javadoc.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP
Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint hornetq-debuginfo-2.2.13-3.fc18.i686.rpm

hornetq-debuginfo.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP
Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint



Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
     present.


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: These BR are not needed: gcc-c++
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint hornetq-devel-2.2.13-3.fc18.i686.rpm

hornetq-devel.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error
403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint hornetq-2.2.13-3.fc18.i686.rpm

hornetq.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
hornetq.i686: W: spelling-error %description -l en_US embeddable -> embedded
hornetq.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error 403:
Forbidden
hornetq.i686: W: no-manual-page-for-binary hornetq-disktest
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint hornetq-2.2.13-3.fc18.src.rpm

hornetq.src: W: spelling-error %description -l en_US multi -> mulch, mufti
hornetq.src: W: spelling-error %description -l en_US embeddable -> embedded
hornetq.src: W: invalid-url URL: http://www.jboss.org/hornetq HTTP Error 403:
Forbidden
hornetq.src: W: invalid-url Source0: hornetq-2.2.13-CLEAN.tar.xz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint hornetq-javadoc-2.2.13-3.fc18.i686.rpm

hornetq-javadoc.i686: W: spelling-error Summary(en_US) Javadocs -> Java docs,
Java-docs, Avocados
hornetq-javadoc.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP
Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint hornetq-debuginfo-2.2.13-3.fc18.i686.rpm

hornetq-debuginfo.i686: W: invalid-url URL: http://www.jboss.org/hornetq HTTP
Error 403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
Package has no sources or they are generated by developer
==> Diff is clean
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Dist tag is present.
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
==> Do you really need Requires: libaoi-devel on the -devel package?
[x]: SHOULD Package functions as described.
[!]: SHOULD Latest version is packaged.
==> It isn't, but with good justification
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
==> I can live with the file names, but see below
[x]: SHOULD Scriptlets must be sane, if used.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
     Note: Source0: hornetq-%{version}-CLEAN.tar.xz
     (hornetq-%{version}-CLEAN.tar.xz) Patch0: 0001-Removed-maven-buildmagic-
     thirdparty-plugin-dependenc.patch (0001-Removed-maven-buildmagic-
     thirdparty-plugin-dependenc.patch) Patch1: 0002-Removed-spring-
     dependency.patch (0002-Removed-spring-dependency.patch) Patch2: 0003-gui-
     aid-changes.patch (0003-gui-aid-changes.patch) Patch3: 0004-JDK7-fix-for-
     FileChannel-constructor.patch (0004-JDK7-fix-for-FileChannel-
     constructor.patch) Patch4: 0005-Libraries-paths.patch (0005-Libraries-
     paths.patch) Patch5: 0006-Make-creation-of-pom-files-easier.patch (0006
     -Make-creation-of-pom-files-easier.patch) Patch6: 0007-Add-jdepend-
     dependency-to-run-javadoc-creation.patch (0007-Add-jdepend-dependency-to-
     run-javadoc-creation.patch) Patch7: 0008-Native-build-fixes.patch (0008
     -Native-build-fixes.patch)
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.


==== Java ====
[x]: MUST If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: MUST Javadoc subpackages have Requires: jpackage-utils
[x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
     symlink)
[ ]: SHOULD Package has BuildArch: noarch (if possible)
[x]: SHOULD Package uses upstream build method (ant/maven/etc.)


==== Maven ====
[x]: MUST Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: MUST Old add_to_maven_depmap macro is not being used
[x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro
[x]: MUST If package contains pom.xml files install it (including depmaps)
     even when building with ant
[x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

Generated by fedora-review 0.1.3
External plugins:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google