|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
* does not build in rawhide: http://koji.fedoraproject.org/koji/getfile?taskID=4093537&name=build.log * unclear license: the spec says GPLv2+, but the tarball contains COPYING (GPLv2) and COPYING.lib (LGPLv2) and both are installed. COPYING is older version of the GPLv2 text and contains wrong FSF address. The same applies to src/package.c, which contains old version of GPLv2 license comment. (It is interesting that it is the only source file with any license specification at all.) * BuildRoot is not required anymore (but I do not mind that) * cleaning buildroot in %install and %clean is not required anymore. Again, I do not mind that, except that "[ "$RPM_BUILD_ROOT" != "/" ]" and "make clean" do not make any sense. * you should not hardcode .gz extension for man pages--use * instead. Also, I think they should be always available -> no %doc. (And I think http://fedoraproject.org/wiki/Packaging/Guidelines#Man_pages implies that.) * you should consider creating versioned library. Unversioned libraries are for development, not distribution.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review