[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 819237] Review Request: vdr-screenshot - Extended screenshot plugin for VDR



Comment # 13 from
(In reply to comment #11)
> (In reply to comment #10)
> > vdr-screenshot.x86_64: W: non-standard-uid
> > /usr/share/locale/tr_TR/LC_MESSAGES/vdr-screenshot.mo vdr
> 
> These errors need fixing, translations should be owned by root, not vdr. 
> Dropping all %defattrs and using plain "%attr(-,%{vdr_user},root) %dir
> %{vdr_cachedir}/screenshot/" just for the dir would be one way to fix it, or
> adding one more %defattr(-,root,root,-) at the end - that's the one that ends
> up affecting stuff passed to %files with -f.
> 
> Non-blocker, but I'd recommend combining the picture-path and readme patches
> into one.
> 
> BTW upstream reported that the *.po patch will be included in the next release.

Ville,

is the rpm package and the review ok ?.


You are receiving this mail because:
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google