Comment # 2
from Shawn Iwinski
(In reply to comment #1)
> Just a quick notes
>
> - LICENSE and README file are installed in /usr/share/pear.
>
> Probably a good idea to ask upstream, this files should be tagged as "doc"
> and
> so installed in /usr/share/doc/pear (and avoid to be duplicated in the
> package)
I will request the change upstream. If they refuse or take a very long to make
the change, is this a blocker? Is it acceptable to use a sed command in the
spec file to modify the package.xml file to change the roles of those files to
doc?
> - Extension dependencies
>
> # phpci print --recursive --report extension Symfony
> -----------------------------------------------------------------------------
> --
> PHP COMPAT INFO EXTENSION SUMMARY
> -----------------------------------------------------------------------------
> --
> EXTENSION PECL VERSION
> COUNT
> -----------------------------------------------------------------------------
> --
> Core 4.0.0
> 309
> SPL 0.2 5.0.0
> 5
> ctype 4.0.4
> 3
> date 4.0.0
> 10
> intl 1.1.0 5.2.4
> 12
> pcre 4.0.0
> 13
> session 4.0.0
> 3
> standard 4.0.0
> 689
> -----------------------------------------------------------------------------
> --
>
> So need to requires php-intl
I'm getting different phpci results and do not see the intl extension listed:
$ uname -a
Linux siwinski-fedora 3.3.2-6.fc16.x86_64 #1 SMP Sat Apr 21 12:43:20 UTC 2012
x86_64 x86_64 x86_64 GNU/Linux
$ phpci --version
phpci version 2.3.0.
$ phpci print --recursive --report extension Form-2.0.14
121 / 121 [+++++++++++++++++++++++++++++++++++++++++++++++++++++++++>] 100.00%
BASE: /home/siwinski/rpmbuild/SOURCES/Form-2.0.14
-------------------------------------------------------------------------------
PHP COMPAT INFO EXTENSION SUMMARY
-------------------------------------------------------------------------------
EXTENSION PECL VERSION COUNT
-------------------------------------------------------------------------------
Core 4.0.0 309
SPL 0.2 5.0.0 5
ctype 4.0.4 3
date 4.0.0 10
pcre 4.0.0 13
session 4.0.0 3
standard 4.0.0 689
-------------------------------------------------------------------------------
A TOTAL OF 7 EXTENSION(S) WERE FOUND
REQUIRED PHP 5.0.0 (MIN)
-------------------------------------------------------------------------------
Time: 7 seconds, Memory: 20.75Mb
-------------------------------------------------------------------------------
> - Other classes dependencies
>
> From package.xml => ok
> Requires: php-pear((%{pear_channel}/EventDispatcher)
> Requires: php-pear((%{pear_channel}/Validator)
> Requires: php-pear((%{pear_channel}/Locale)
>
> And optionnaly (your decision)
> Requires: php-pear((%{pear_channel}/HttpFoundation)
I would prefer to let end-users decide if they want to use optional PEAR
packages
> - directory ownership
>
> %dir %{pear_phpdir}/Symfony/Component
> %dir %{pear_phpdir}/Symfony
>
> You don't need to own this directories which are already owned by required
> packages.
I was just keeping the spec files consistent. May I just comment out the those
2 lines and add a note as to why they are commented out, or do you want me to
delete them?
