[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 812384] Review Request: ghc-sendfile - Portable sendfile library



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812384

Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #2 from Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> 2012-05-05 02:44:20 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint  -i ghc-sendfile-0.7.6-1.fc15.x86_64.rpm
ghc-sendfile-0.7.6-1.fc15.src.rpm ghc-sendfile-devel-0.7.6-1.fc15.x86_64.rpm 
../ghc-sendfile.spec 
ghc-sendfile.x86_64: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.

ghc-sendfile.src: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.

ghc-sendfile-devel.x86_64: W: spelling-error %description -l en_US haskell ->
Haskell
The value of this tag appears to be misspelled. Please double-check.

3 packages and 1 specfiles checked; 0 errors, 3 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package.

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
BSD license
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum sendfile-0.7.6.tar.gz 
4dea8d9f853fee4797f81e74791bd09e  sendfile-0.7.6.tar.gz

md5sum ghc-sendfile-0.7.6-1.fc16.src/sendfile-0.7.6.tar.gz 
4dea8d9f853fee4797f81e74791bd09e 
ghc-sendfile-0.7.6-1.fc16.src/sendfile-0.7.6.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
rpm -e  ghc-sendfile-0.7.6-1.fc15.x86_64
error: Failed dependencies:
        ghc(sendfile-0.7.6) = d2baade88e666ebbe0f254e473584d8d is needed by
(installed) ghc-sendfile-devel-0.7.6-1.fc15.x86_64
        ghc-sendfile = 0.7.6-1.fc15 is needed by (installed)
ghc-sendfile-devel-0.7.6-1.fc15.x86_64
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installs fine. Loaded Network.Socket.SendFile into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google