[Bug 814887] Review Request: encuentro - Content visualization of the Canal Encuentro.

[bugzilla@xxxxxxxxxx]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814887

--- Comment #15 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2012-04-25 23:32:05 EDT ---
FIXED:
* %build and %install taken care of.  Package now builds
* Documentation added
* desktop-file-validate is now used
* File permissions are good
* All filenames are utf-8
* Files and directories created by this package are owned by it

NEEDS FIXING:
* Does not build in koji or mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=4023608
    /var/tmp/rpm-tmp.n8J0EZ: line 33: /usr/bin/python: No such file or
directory
  You need to pull python into the build like this:
    BuildRequire: python2-devel
* We're not currently shipping apport in Fedora so we shouldn't be shipping the
  apport files

COSMETIC:
* It's recommended that when including a directory in the %file list you use a
  trailing slash.  That way other people (future package maintainers,
  reviewers, etc) know that you intend to include the directory.  So it would
  look like this:
  %{_datadir}/encuentro/
* Description (and changelog) lines should be no more than 80 characters.

rpmlint:
- encuentro.noarch: W: summary-ended-with-dot C Content visualization of the
Canal Encuentro.
  Don't use a period in the Summary

- encuentro.noarch: W: name-repeated-in-summary C Encuentro
  Is Canal Encuentro the proper name of a "place"/project/similar?  If so, this
  warning can be ignored

- encuentro.noarch: E: description-line-too-long C This is a simple program to
search, download and see the content of the Canal Encuentro.
  Lines should be less than 80 characters

- encuentro.noarch: W: non-standard-group Multimedia
  Ignorable, we don't use the Group tag in Fedora.

- encuentro.noarch: E: non-executable-script
/usr/share/encuentro/encuentro/__init__.py 0644L /usr/bin/python
  This is because __init__.py has a shebang line (#!/usr/bin/python) but isn't
really a script.
  You can get rid of the error by deleting that line using sed in %prep:
  sed -i '1d' encuentro/__init__.py

- encuentro.noarch: W: no-manual-page-for-binary encuentro
  This is a warning that there's no man page.  If one exists somewhere (for
  instance in the Debian package) you can include it in our package.

- encuentro.src:29: W: setup-not-quiet
  We usually give the -q flag to %setup.  So the %setup in your package would
be:
  %setup -qn %{name}-%{version}

- encuentro.src:58: W: macro-in-%changelog %build
  Macros are expanded no matter where in the file they are (comments,
  changelog, description, etc).  They should be escaped when you don't
  mean to use them.  Like: %%build.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review