[Bug 811418] Review Request: rubygem-hydra - distributes tests for speed

[bugzilla@xxxxxxxxxx]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=811418

--- Comment #6 from Matt Hicks <mhicks@xxxxxxxxxx> 2012-04-25 08:54:13 EDT ---
Latest round:

Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra.spec

SRPM URL:
http://matthicksj.fedorapeople.org/reviews/rubygem-hydra-0.24.0-1.fc16.src.rpm

I've updated the conditions to use el5 / el6.

Had one question around the 'Requires: rubygems'.  In the old packaging
guidelines, they had:

The package must have a Requires and a BuildRequires on rubygems

However, I used the format above 'Requires: ruby(rubygems)' as I saw that used
in a couple of other RPM's.  Any advice on the right approach?  I could do the
following:

1. Change 'Require: ruby(rubygems)' to 'Require: rubygems'.  That would meet
the old ruby packaging guidelines and I believe should functionally work.

2. I could modify the conditional to include the following

%if 0%{?el5}%{?el6}
Requires: rubygems
BuildRequires: rubygems
%else
Requires: ruby(rubygems)
BuildRequires: rubygems-devel
%endif

Thanks again for your help

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review