[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 815951] Review Request: weston - Reference compositor for Wayland



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815951

--- Comment #3 from Richard Hughes <rhughes@xxxxxxxxxx> 2012-04-25 08:03:22 EDT ---
(In reply to comment #2)
> Few notes:
> 
> * You may drop %clean section entirely. I believe this package isn't intended
> to run on onl EL boxes.

Correct, fixed.

> * Unowned directories
> ** %{_libdir}/weston/
> ** %{_libdir}/weston/
> Either specifically mark them as %dir in the %files section or change %files
> section to that

Fixed, thanks.

> * I don't like this line
> autoreconf -v --install || exit 1
> So if autoreconf were fail for whatever reason what would we expect then?
> Successful building?
> Can you simplify this to "autoreconv -ivf" (notice -f switch)?

Yup, done.

> * License field is wron. Must be "BSD and CC-BY-SA". The latter is for content.

Agreed, fixed.

> So, please, address/explain my notes and I'll finish it.

New files: 
http://people.freedesktop.org/~hughsient/temp/weston.spec
http://people.freedesktop.org/~hughsient/temp/weston-0.89-0.3.fc17.src.rpm

Thanks for the super-quick turnaround.

Richard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google