[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 814916] Review Request: sratom - a C library for serializing LV2 plugins



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814916

Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #6 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2012-04-22 15:40:58 EDT ---
Fedora Review sratom 2012-04-22

$ rpmlint sratom*.rpm
sratom.src: W: spelling-error Summary(en_US) serialising -> serializing,
serialization
sratom.src: W: spelling-error %description -l en_US serialising -> serializing,
serialization
sratom.src: W: spelling-error %description -l en_US serialisation ->
serialization, sensationalist, sensationalism
sratom.src: W: spelling-error %description -l en_US serialise -> serialize,
serial, aerialist
sratom.x86_64: W: spelling-error Summary(en_US) serialising -> serializing,
serialization
sratom.x86_64: W: spelling-error %description -l en_US serialising ->
serializing, serialization
sratom.x86_64: W: spelling-error %description -l en_US serialisation ->
serialization, sensationalist, sensationalism
sratom.x86_64: W: spelling-error %description -l en_US serialise -> serialize,
serial, aerialist
sratom-devel.x86_64: W: spelling-error %description -l en_US serialising ->
serializing, serialization
sratom-devel.x86_64: W: spelling-error %description -l en_US serialisation ->
serialization, sensationalist, sensationalism
sratom-devel.x86_64: W: spelling-error %description -l en_US serialise ->
serialize, serial, aerialist
4 packages and 0 specfiles checked; 0 errors, 11 warnings.

Clean except for American English spelling in Summary and Description.


+ Package name according to guidelines
+ Specfile named after package
+ Package license (MIT) Fedora approved
+ Package license reflects license as stated in the sources
+ License file (COPYING) included as %doc

- Specfile uses British spelling in summary and description
  This should be changed to American spelling according to guidelines
  See also the rpmlint report above

+ Specfile is readable
+ Source matches upstream

$ md5sum sratom-0.2.0.tar.bz2 srpm/sratom-0.2.0.tar.bz2 
c03cf2849186818610ffe889be4f5b55  sratom-0.2.0.tar.bz2
c03cf2849186818610ffe889be4f5b55  srpm/sratom-0.2.0.tar.bz2

- Package fail to build due to missing BuildRequires: python

./waf configure -v --prefix=/usr --libdir=/usr/lib64 --mandir=/usr/share/man
--datadir=/usr/share --docdir=/usr/share/doc/sratom-devel-0.2.0 --test --docs
/usr/bin/env: python: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.3g1rbM (%build)

[ Also my rebuild of the lv2 package on which this package depends failed with
the same error ]

+ No locales
+ Scriptlets call ldconfig
+ No bundled libraries
+ Package owns directories it creates
+ No duplicates in %files
+ File permissions are sane
+ Specfile uses macros consistently
+ Contains code
+ Documentation is in -devel, though can be considered small
+ %doc not runtime essential
+ No static libraries
+ Headers and develoment library symlinks in -devel
+ -devel requires main with fully qualified version
+ No .la files
+ Package does not own ohters' libraries
+ Filenames valid UTF8

Summary:

Fix American spelling and add missing BR on python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google