[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 806446] Re-Review Request: musique (replacing minitunes) - A music player designed by and for people that love music



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806446

Gregor Tätzner <gregor@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gregor@xxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |gregor@xxxxxxxxxx

--- Comment #3 from Gregor Tätzner <gregor@xxxxxxxxxx> 2012-04-09 17:09:48 EDT ---
I'm going to take this review

first look:

- remove gcc-c++ build req
it's not necessary

- add icon scriptlets
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

- install or validate the desktop file

- did you actually test the translation? In the past we had some problems with
software from this upstream. If you want to see how it's done right have a look
at minitube (from rpmfusion)

- remove INSTALL file from doc - users just install the package :)

- and have a look at the remove-qtsingleapp patch in minitube. musique is
bundling the same lib too and this is not allowed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google