[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 810059] opencl-utils - Useful OpenCL tools and utilities



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810059

--- Comment #3 from Jeremy Newton <alexjnewt@xxxxxxxxxxx> 2012-04-05 11:36:26 EDT ---
(In reply to comment #1)
> Just some initial remarks, no references (drop a line if need be).
> - As for the missing doc, file a bug upstream to add the license file.

Yeah I plan to focus on that once I get the rest working

> - The examples might just go into -devel IMHO.

Hmmm, I figure I should look into building them in that case, it maybe more
convienient to have them built along with the source; I've seen some packages
work like this.

> - You need to somehow use %{optflags} in the Makefile.
> - Makefile contains a 'strip' command which should be removed.
> - opencl-utils-debuginfo.i686: E: empty-debuginfo-package related to above.

Noted, I'll see what I can do.

> - Since this a library intended to be used by other programs, the Makefile
> should be patched to include a soname (a %global macro), and symlinks setup
> accordingly. That patch should be acceptable upstream.

I have no idea how to do the symlink part, the soname part seems easy though. I
would think the soname part can be fixed like so:
>sed -i 's/ldl/ldl -Wl,-soname,libclrun.so.0/g' src/clrun/Makefile
Although can you lend me a hand for the symlink? :)

> - The description for -devel says 'source code'; shouldn't that be 'header
> files'?

Not necessarily, it can be the source too, though it maynot be necessary if I
can figure out how to patch dolphin-emu to use the *.so instead of rebuilding
it.

> - The debug package name opencl-utils-debuginfo is not consistent w the others.

I just realized I need to make a opencl-utils-devel along with a CLRun-devel; I
by accident put all the files in CLRun-devel instead.

> 
> --- *spec.ORG 2012-04-05 09:16:17.211177855 +0200
> +++ opencl-utils.spec 2012-04-05 09:17:25.477104941 +0200
> @@ -18,6 +18,8 @@
> 
> #http://code.google.com/p/dolphin-emu/source/browse/Externals/CLRun/clrun/generateClRun.pl
>  Patch1:         %{name}-trimwhitespace.patch
> 
> +BuildRequires: mesa-libGL-devel
> +
>  %package     -n CLRun
>  Summary:        Dynamic loader for OpenCL

Thanks! I knew I forgot something.

(In reply to comment #2)
> A second thought on naming: the %name macro is set to upstream's name
> opencl-utils. However, you override it everywhere and the package is
> effectively named CLrun. This does *not* match the upstream name.
> 
> I suggest that you name the packages to the default opencl-utils-*. Just live
> with the fact that only clrun is packaged, making a note in the %descr about
> it. If/when someone else needs more packaged it's just to fix, but without
> changing the package name.

Good point, that would make more sense, thanks! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google