[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Google
  Web www.spinics.net

[Bug 705108] Review Request: shinken - python monitoring tool



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705108

Jorge A Gallegos <kad@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kad@xxxxxxxxx

--- Comment #14 from Jorge A Gallegos <kad@xxxxxxxxx> 2012-04-02 15:02:31 EDT ---
(In reply to comment #11)
> Hi,
> 
> Requires in the sub packages have been removed and i putting the Requires on
> one line each.
> 
> After discussion with the developer of Shinken, Shinken plugins can be place on
> Nagios Plugins but it's possible to put in an other directory. 
> 
> Shinken was released in version 0.6.5. I still have tests to do before
> uploading the SRPM and SPEC.
> 
> Best regard

I think most of the issues have been worked out for this spec? Some comments:

 - I'd still change %{_libdir}/nagios to %{_libdir}/shinken, because that
directory is already owned by the nagios package I think
 - You're sed'ing /usr/bin/python as the interpreter on several files, I would
put /usr/bin/env python instead (not sure if shinken is python3 compatible or
etc)
 - Volker was probably referring to that python_sitelib macro you have on top,
check http://fedoraproject.org/wiki/Packaging:Python#Macros, since you stated
you want shinken to be supported in fedora 15+: "In Fedora 13 and greater, the
following macros are defined for you: ... snip... python_sitelib" 
 - Also, seems like shinken is up to v1.0.1
(http://www.shinken-monitoring.org/download/) so maybe you should update from
upstream too?

Otherwise, very exciting! I'd like to see shinken in fedora some time soon!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

Add to Google