[Bug 800930] Review Request: redeclipse - Multiplayer FPS game based on Cube2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800930

--- Comment #15 from Martin Erik Werner <martinerikwerner@xxxxxxxxx> 2012-03-09 08:39:37 EST ---
(In reply to comment #14)
> Getting there!
> 
> When you make changes to your spec its customary to bump the release number and
> annotate in the %changlog like so:
> 
> * Wed Feb 29 2012 Martin Erik Werner <martinerikwerner@xxxxxxxxx> 1.2-3
> - blah
> 
> * Wed Feb 29 2012 Martin Erik Werner <martinerikwerner@xxxxxxxxx> 1.2-2
> - blah

Even during the review procss?
I though that was only for changes that are made between actual Fedora
releases?
Or in the case of a first release, major things which differ compared to
upstream (i.e. the patches).

> 
> Also keep you spec file column with under 72 for readability (except where its
> not feasible for scripts), I'd also suggest having separate lines for each of
> your BuildRequires

Ok, fixed, I was doing 80, since that was mentioned for %description

> 
> And Its also customary to order your tags like so:
> 
> %package -n blah1
> 
> %description -n blah1
> 
> %package -n blah2
> 
> %description -n blah2

Ok, done

> 
> You can also drop rm -rf %{buildroot} from your %install section
>

Ah, true, targeting EPEL 5 might be a bit excessive, done

> Change %{_mandir}/man6/%{name}-server.6.gz to
> %{_mandir}/man6/%{name}-server.6.* to allow for changes in compression format
> in subsequent releases

Done

> 
> Have a look at http://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir.
> Move the executables to %_bindir if these executables are to be run directly by
> users and not via the main executable.

The game needs to be executed via wrapper scripts since it looks in the working
dir for the data files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]