Re: system-config-soundcard

Matias Feliciano <feliciano.matias@xxxxxxx> · Fri, 01 Oct 2004 01:07:41 +0200

Le jeu 30/09/2004 Ã 09:33, Bastien Nocera a Ãcrit :
> Hello Matias, Jeff,
> 
> On Thu, 2004-09-30 at 05:50 +0200, Matias Feliciano wrote:
> > I don't know if it's a issue since Fedora (s-c-sc) doesn't support it
> > anymore.
> 
> Support for multiple soundcards was never in the code,

Are you sure ?
Don't understand.

>  and that it even
> unmutes the first card is a bit of magic, as there isn't any code to do
> that in there.
> 

What is that :
            amixer_path = "/usr/bin/amixer"
            amixer_pid = os.fork()
            amixer_args = [amixer_path, "-q", "sset", "Master", "75%", "on"]

> > > so at least those 2 issues should be filed in 2 seperate reports.
> > > 
> > > Also if you have enhanced the codebase
> > 
> > No user visible enhancement (except bugfix).
> > 
> > >  you will want to create a patch
> > > file that contains the differences between the original and yours and
> > > attach the patch file to the appropriate bug report.
> > 
> > Not easy for each bugs. The patch is here :
> > http://feliciano.matias.free.fr/system-config-soundcard/mat.patch
> 
> Well, you'll need to split up the patch. Currently, it's not mergeable.
> And as we're in a freeze, I can't even merge the bug fixes you've made:
> http://fedora.redhat.com/participate/schedule/
> 

OK

> > >  Futher discussion
> > > of the value of the patches though and how to best re-work them if
> > > re-working is needed is done in the system-config-soundcard.
> > 
> > 
> > >   Its good
> > > that you have taken the initiative to  play around with the codebase
> > > and hack on it a little. But the best thing you can do is get on the
> > > fedora-config-list and see if you can get some feedback from other
> > > developers about your code.
> > 
> > OK, move to fedora-config-list
> > The initial post is here :
> > http://www.redhat.com/archives/fedora-test-list/2004-September/msg01634.html
> > 
> > And this is my following question for fedora-test-list :
> >         Does system-config-soundcard have to continue to load all
> >         modules whereas initscript/kmodule should do this job ?
> 
> system-config-soundcard doesn't load the modules anymore,

Fixed :
http://feliciano.matias.free.fr/system-config-soundcard/

>  they're auto-
> loaded when the drivers are needed.

With udev ? No.

> Please, follow Jeff's advices if you want those bugs to be fixed soon.

Seems too later for FC3.
To be honest, i don't want to split my patch.
This is too much work and ugly.
soundcardBackend.py is the more modified file. Check this :
wc -l system-config-soundcard-1.2.10.orig/src/soundcardBackend.py system-config-soundcard-1.2.10/src/soundcardBackend.py
  298 system-config-soundcard-1.2.10.orig/src/soundcardBackend.py
  138 system-config-soundcard-1.2.10/src/soundcardBackend.py

diff -uN system-config-soundcard-1.2.10.orig/src/soundcardBackend.py system-config-soundcard-1.2.10/src/soundcardBackend.py | diffstat
 soundcardBackend.py |  300
++++++++++++----------------------------------------
 1 files changed, 70 insertions(+), 230 deletions(-)

How can I build independant patch for each bug ?

btw, is it too hard to verify a 140 lines file ?