Re: [PATCH 15/20] Move swsusp __pa() dependent code to arch portion

[Pavel Machek <pavel@xxxxxx>]

Hi!

> o __pa() should be used only on kernel linearly mapped virtual addresses
>   and not on kernel text and data addresses.
> 
> o Hibernation code needs to determine the physical address associated
>   with kernel symbol to mark a section boundary which contains pages which
>   don't have to be saved and restored during hibernate/resume operation.
> 
> o Move this piece of code in arch dependent section. So that architectures
>   which don't have kernel text/data mapped into kernel linearly mapped
>   region can come up with their own ways of determining physical addresses
>   associated with a kernel text.
> 
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

...hmm, but that means 3 copies of same code. Can we put the

> +/*
> + *	pfn_is_nosave - check if given pfn is in the 'nosave' section
> + */
> +
> +int pfn_is_nosave(unsigned long pfn)
> +{
> +	unsigned long nosave_begin_pfn = __pa_symbol(&__nosave_begin) >> PAGE_SHIFT;
> +	unsigned long nosave_end_pfn = PAGE_ALIGN(__pa_symbol(&__nosave_end)) >> PAGE_SHIFT;
> +	return (pfn >= nosave_begin_pfn) && (pfn < nosave_end_pfn);
> +}

...in asm-generic/suspend.h (or something) and then just include it?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
fastboot mailing list
fastboot@xxxxxxxxxxxxxx
https://lists.osdl.org/mailman/listinfo/fastboot