[PATCH] Keep alignment comment in elf code and use KERNEL_CMDLINE_ALIGN

[vgoyal at in.ibm.com (Vivek Goyal)]

On Thu, Feb 15, 2007 at 05:24:04PM +0900, Magnus Damm wrote:
> Keep alignment comment in elf code and use KERNEL_CMDLINE_ALIGN
> 
> This patch puts back the alignment comment to crashdump-elf.c and
> adds a small check to make sure the arch-specific code aligns properly.
> Instead of hardcoding 1024 we introduce KERNEL_CMDLINE_ALIGN.
> 
> The idea behind the alignment requirement is explained here:
> http://lists.osdl.org/mailman/htdig/fastboot/2006-November/005147.html
> 
> Signed-off-by: Magnus Damm <magnus at valinux.co.jp>
> ---
> 

Hi Magnus,

This patch looks good. A minor nit. Somehow I find the name
KERNEL_CMDLINE_ALIGN to be not very intutive in this context. How
about something like ELF_CORE_HEADER_ALIGN? This will mean that
above value puts alignment restriction on elf core headers. And comment
will clarify why it needs to be atleast 1K.

Thanks
Vivek