[PATCH 005/013] kexec-tools: Make use of crash_create_elf64_headers() (x86_64)

[vgoyal at in.ibm.com (Vivek Goyal)]

On Fri, Nov 17, 2006 at 07:56:59PM +0900, Magnus Damm wrote:
> kexec-tools: Make use of crash_create_elf64_headers() (x86_64)
> 
> Use the new function provided by crashdump-elf.c instead of duplicating the
> same functionality in prepare_crash_memory_elf64_headers().
> 
> This patch also includes a bugfix for the case when space for the kernel
> PT_LOAD program header is written but never allocated.
> 
> Signed-off-by: Magnus Damm <magnus at valinux.co.jp>
> ---
> 
>  kexec/arch/x86_64/crashdump-x86_64.c |  161 +++-------------------------------
>  1 file changed, 15 insertions(+), 146 deletions(-)
> 
> --- 0002/kexec/arch/x86_64/crashdump-x86_64.c
> +++ work/kexec/arch/x86_64/crashdump-x86_64.c	2006-11-17 15:23:43.000000000 +0900
> @@ -37,6 +37,18 @@
>  #include "crashdump-x86_64.h"
>  #include <x86/x86-linux.h>
> 
> +static struct crash_elf_info elf_info = 
> +{
> +	class: ELFCLASS64,
> +	data: ELFDATA2LSB,
> +	machine: EM_X86_64,
> +	alignment: 1024,

This alignment thing is confusing me. Can you give some more details please?

Otherwise patch looks good to me.

Thanks
Vivek