[patch 00/11] kexec-tools: ia64 purgatory readability cleanup

[horms at verge.net.au (Horms)]

On Thu, Sep 21, 2006 at 10:44:58AM +0900, Horms wrote:
> On Thu, Sep 21, 2006 at 09:01:39AM +0800, Zou, Nanhai wrote:
> > > -----Original Message-----
> > > From: Horms [mailto:horms at verge.net.au]
> > > Sent: 2006?9?20? 15:29
> > > To: fastboot at lists.osdl.org
> > > Cc: Zou, Nanhai; Eric W. Biederman; Maneesh Soni; Vivek Goyal
> > > Subject: [patch 00/11] kexec-tools: ia64 purgatory readability cleanup
> > > 
> > > Hi,
> > > 
> > > while examining the code in purgatory/arch/ia64/purgatory-ia64.c
> > > I had a lot of trouble following what is going on, even
> > > though the code is quite short. The following series of patches
> > > aims to make the code somewhat easier to read.
> > > 
> > > I have tested this code fairly extensively and it seems to be working
> > > quite well. I'd like to merge it into kexec-tools-testing. I would
> > > be most grateful of some review.
> > > 
> >   I am ok with all the patches. 
> >   Though I think *p1 = *p2 is as readable as memcpy(p1, p2, sizeof(*p1)); and it saves a lot of typing. :)
> 
> You have a good point there, I'll drop that patch.

I have removed the memcpy patch, refactored some of the other patches
accordingly, and committed to kexec-tools-testing.

Thanks

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/