Re: [PATCH] Allow the user to restrict the RC5 address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thursday 26 March 2009 19:45:53 Udo A. Steinberg wrote:
> On Thu, 26 Mar 2009 12:45:18 -0400 Steven Toth (ST) wrote:
> ST> I too tend to have multiple remotes, I don't think it's that unusual
> for ST> long standing Hauppauge customers to have many boards with many
> types of ST> remotes.
> ST>
> ST> > It might be better to have an option to explicitly allow old
> Hauppauge ST> > remotes that send 0x00.
> ST> >
> ST> I could live with this. It relegates older remotes but those remotes
> ST> are no longer made. This feels like a good compromise.
> How about changing the parameter such that it is a filter mask? The
> default value of 0x0 would accept all remotes. For non-zero values, each
> bit set in the parameter would filter the device address corresponding to
> that bit, e.g. 0x1 would filter address 0x0, 0x80000000 would filter
> address 0x1f, etc.

Seems way to complicated to me. Remember that end users have no idea about 
the device addresses, so it should be a simple to understand module option. 
So I'd just go with Steve's preference.



> Cheers,
> 	- Udo

Hans Verkuil - video4linux developer - sponsored by TANDBERG

v4l-dvb-maintainer mailing list

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

Add to Google Powered by Linux

Google PageRank Checking tool