Google
  Web www.spinics.net

Re: [VIDEO4LINUX] removed unused #include <version.h>'s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sunday 04 January 2009, Trent Piepho wrote:
> On Sun, 4 Jan 2009, Laurent Pinchart wrote:
> > On Sunday 04 January 2009, Huang Weiyi wrote:
> > > Removed unused #include <version.h>'s in files below,
> > >   drivers/media/video/cs5345.c
> > >   drivers/media/video/pwc/pwc-if.c
> > >   drivers/media/video/saa717x.c
> > >   drivers/media/video/upd64031a.c
> > >   drivers/media/video/upd64083.c
> > >   drivers/media/video/uvc/uvc_ctrl.c
> > >   drivers/media/video/uvc/uvc_driver.c
> > >   drivers/media/video/uvc/uvc_queue.c
> > >   drivers/media/video/uvc/uvc_video.c
> >
> > You can remove it from drivers/media/video/uvc/uvc_status.c as well.
> >
> > Mauro, the #include <linux/version.h> are required for backward
> > compatibility in the Mercurial tree, but are not needed (except in
> > uvc_v4l2.c) in the mainline git kernel tree. Can that be handled by your
> > Mercurial -> git export scripts ?
>
> The version.h includes should not be needed for backward compatibility in
> the Hg tree.  There was always a problem with version.h appearing to not be
> necessary in the git code, so I modified the v4l-dvb build system to add
> version.h with a gcc -include option.

Thanks for the information.

Huang, can you please resubmit a patch with #include <linux/version.h> removed 
from drivers/media/video/uvc/uvc_status.c as well ?

Best regards,

Laurent Pinchart

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool