Re: drivers/media/dvb/frontends/cx24116.c warning | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
Hi Darron,
I found some troubles on your patch as described bellow. This time, I've picked
your patches and applied. Please, next time, try to follow the proper
procedures, as described bellow.
Cheers,
Mauro.
On Wed, 17 Dec 2008 13:00:55 +0000
Darron Broad <darron@xxxxxxxx> wrote:
> In message <20081216140819.4a6ec3b6.akpm@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton wrote:
>
> hi.
>
> >drivers/media/dvb/frontends/cx24116.c: In function 'cx24116_set_frontend':
> >drivers/media/dvb/frontends/cx24116.c:1208: warning: 'retune' may be used uninitialized in this function
> >
> >seems to be true?
>
> This bug was introduced in changeset: 9170:70ee86a7c630
>
> The error has been reverted and can be found here:
> http://hg.kewl.org/v4l-dvb-cx24116/
>
> There are also other fixes for cx24116.
>
> Please review and merge as you see fit.
Please, don't ask Andrew to review/merge your v4l/dvb code on your -hg tree. He
only accepts inline patches, and he will ask me later to review. So, the better
is to send it to me directly.
>From my side, the proper procedure for -hg pull requests is to send me a pull
request, c/c v4l-dvb-maintainer@xxxxxxxxxxx (it is ok to copy other people like
Andrew, if you want), with a subject like:
[PULL] http://hg.kewl.org/v4l-dvb-cx24116/
You can see some examples on how this is done by others at the lists archive:
http://www.linuxtv.org/pipermail/v4l-dvb-maintainer/
Also, please check your patches with checkpatch.pl before committing it. A few
of them were violating coding style:
cx24116: bugfix: add missing delsys in FEC lookup
ERROR: space prohibited after that open parenthesis '('
#42: FILE: linux/drivers/media/dvb/frontends/cx24116.c:422:
+ if ( (d == CX24116_MODFEC_MODES[i].delivery_system) &&
WARNING: line over 80 characters
#76: FILE: linux/drivers/media/dvb/frontends/cx24116.c:1320:
+ ret = cx24116_set_fec(state, c->delivery_system, c->modulation, c->fec_inner);
total: 1 errors, 1 warnings, 61 lines checked
dvb-core: don't add an event when in ONE SHOT mode for algo type HW
WARNING: line over 80 characters
#26: FILE: linux/drivers/media/dvb/dvb-core/dvb_frontend.c:594:
+ if (s != fepriv->status && !(fepriv->tune_mode_flags & FE_TUNE_MODE_ONESHOT)) {
total: 0 errors, 1 warnings, 8 lines checked
cx24116: change to ALGO_HW
WARNING: line over 80 characters
#95: FILE: linux/drivers/media/dvb/frontends/cx24116.c:1451:
+static int cx24116_tune(struct dvb_frontend *fe, struct dvb_frontend_parameters *params,
total: 0 errors, 1 warnings, 48 lines checked
cx88: advise/acquire clean-up for HVR-1300/3000/4000
ERROR: trailing whitespace
#103: FILE: linux/drivers/media/video/cx88/cx88-dvb.c:1169:
+^I^I^Icx_write(MO_SRST_IO, 0); $
total: 1 errors, 0 warnings, 86 lines checked
Please, be sure to ask first the driver maintainer for taking a review before
asking me to pull. If you couldn't reach him on a reasonable time, you may add
a CC tag like:
CC: Some email author <his@xxxxxxxxxxx>
The linuxtv.org mailbomb script will send copies to the author for him to be
aware that the patch were applied.
It would be interesting if you can read the patch submission rules at:
http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches
This file points also to some Kernel documents describing how to write a patch,
how to check for coding style issues, etc.
Cheers,
Mauro
_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
|
|
-->
