Google
  Web www.spinics.net

Re: [PULL] soc-camera: ov772x updates, pixel format negotiation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 8 Dec 2008, Mauro Carvalho Chehab wrote:

> On Mon, 1 Dec 2008 13:53:30 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> 
> > On Mon, 1 Dec 2008, Guennadi Liakhovetski wrote:
> > 
> > > Hi Mauro,
> > 
> > Sorry, after sending the pull-request I realised, that I forgot my Sob 
> > undre 2 of 9 patches:-( So, I re-cloned, and re-pushed. The nodes have 
> > changed now though - do you want me to re-generate the pull-request or you 
> > don't use them? Tell me if the newly cloned tree is ok, I'll remove the 
> > old one then (marked "-bad" for now).
> > 
> > Thanks
> > Guennadi
> > 
> > > 
> > > Please pull from http://linuxtv.org/hg/~gliakhovetski/v4l-dvb
> > > 
> > > for the following 9 changesets:
> > > 
> > > 01/09: Change power on/off sequence on ov772x
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=4c445e20c298
> 
> You are also forgetting to add the "From" meta-tag. We use this to proper
> attribute the user author for each patch. Please add it (mailimport script is a
> good option to import patches from other authors, since it does some sanity
> check).
> 
> For example, in this changeset,
> 
> # HG changeset patch
> # User Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> # Date 1228135488 -3600
> # Node ID 45e1e6ffe8f0e586a442b77251f9a36bc40a4089
> # Parent 7100e78482d70ee9acf90f2c15848f6002f89b7d
> Change power on/off sequence on ov772x
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> 
> 
> I'm assuming that the author ("From") is Kuninori, right? Please double check
> the patches after I merge it at -git.

Wow... But the "User" above has it right:

> # User Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>

and what I've done was imported his email into git for testing, then 
re-exported using git-format-patch, then imported into hg with hg import 
(looking forward to v4l switching to git...), otherwise where would it get 
its "User" mark from? Is it not enough? I think I've been doing all my hg 
patches this way up to now...

Thanks
Guennadi

> 
> 
> > > 
> > > 02/09: Register name fix for ov772x driver
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=0fd9e0c03485
> > > 
> > > 03/09: soc-camera: merge .try_bus_param() into .try_fmt_cap()
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=8df9aada7e0c
> > > 
> > > 04/09: soc-camera: formatting fixes
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=fc73f1c89275
> > > 
> > > 05/09: soc-camera: let camera host drivers decide upon pixel format
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=3e47e79c1c46
> > > 
> > > 06/09: soc-camera: simplify naming
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=3ab02c4f0712
> > > 
> > > 07/09: soc-camera: add a per-camera device host private data pointer
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=b7b1352e8409
> > > 
> > > 08/09: soc-camera: pixel format negotiation - core support
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=6d3786b06500
> > > 
> > > 09/09: pxa-camera: pixel format negotiation
> > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=3d39cbd4f562
> > > 
> > > 
> > >  drivers/media/video/mt9m001.c              |   14 -
> > >  drivers/media/video/mt9m111.c              |   12 -
> > >  drivers/media/video/mt9v022.c              |   14 -
> > >  drivers/media/video/ov772x.c               |   97 +++++-----
> > >  drivers/media/video/pxa_camera.c           |  259 +++++++++++++++++++++++------
> > >  drivers/media/video/sh_mobile_ceu_camera.c |   54 ++++--
> > >  drivers/media/video/soc_camera.c           |  178 ++++++++++++-------
> > >  drivers/media/video/soc_camera_platform.c  |   12 -
> > >  include/media/soc_camera.h                 |   40 +++-
> > >  9 files changed, 476 insertions(+), 204 deletions(-)
> > > 
> > > Thanks,
> > > Guennadi
> > > ---
> > > Guennadi Liakhovetski, Ph.D.
> > > Freelance Open-Source Software Developer
> > > 
> > 
> > ---
> > Guennadi Liakhovetski, Ph.D.
> > Freelance Open-Source Software Developer
> 
> 
> 
> 
> Cheers,
> Mauro
> 

---
Guennadi Liakhovetski

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool