Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

[Hans Verkuil <hverkuil@xxxxxxxxx>]

Hi Erik,

On Thursday 20 November 2008 16:52:09 Erik Andrén wrote:
> 2008/11/20 Hans Verkuil <hverkuil@xxxxxxxxx>:
> > Hi Mauro,
> >
> > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for
> > the following:
> >
> > - af9015: fix compilation error
> > - compat.h: fix uninitialized_var macro
> > - m5602: move static struct from header to source.
>
> Hi, did you pull my commit implementing this or did you patch it
> yourself?

I did it myself. I wasn't aware of a pull request from you.

Hmm, they are basically identical except that I use this:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 24)
static const struct dmi_system_id ov9650_flip_dmi_table[] = {
#else
static struct dmi_system_id ov9650_flip_dmi_table[] = {
#endif

rather than this:

static
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 24)
    const
#endif
       struct dmi_system_id ov9650_flip_dmi_table[] = {

Personally I prefer my approach since when the source is stripped by 
gentree the latter version will look like this:

static
    const
       struct dmi_system_id ov9650_flip_dmi_table[] = {

But I leave it up to Mauro to decide. I'm happy as long as the warnings 
disappear from the build! :-)

BTW: In general I don't understand why these tables are in the header at 
all. Static data in a header seems very dubious to me. If the other 
remaining tables in those headers are only used inside the C-source, 
then I suggest moving the other over as well.

Just my opinion though.

Regards,

	Hans

>
> Regards,
> Erik
>
> > - em28xx: fix compile warnings
> >
> > With these changes I'm almost back to a full OK result in the daily
> > build. One issue remains, but that needs to be filtered out by the
> > build script itself.
> >
> > Thanks,
> >
> >        Hans
> >
> > diffstat:
> >  linux/drivers/media/dvb/dvb-usb/af9015.c             |   12 +++---
> >  linux/drivers/media/video/em28xx/em28xx-video.c      |    2 -
> >  linux/drivers/media/video/gspca/m5602/m5602_ov9650.c |   38
> > +++++++++++++++++++
> >  linux/drivers/media/video/gspca/m5602/m5602_ov9650.h |   38
> > -------------------
> >  linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c |   30
> > +++++++++++++++
> > linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.h |   30
> > --------------- v4l/compat.h                                       
> >  |    2 - 7 files changed, 75 insertions(+), 77 deletions(-)
> > marune: /marune/build/v4l-dvb $ cd ..
> >
> >
> >
> > _______________________________________________
> > v4l-dvb-maintainer mailing list
> > v4l-dvb-maintainer@xxxxxxxxxxx
> > http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer



_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer