Re: [PULL] http://linuxtv.org/hg/~awalls/cx18-bugfix

[Andy Walls <awalls@xxxxxxxxx>]

On Wed, 2008-11-12 at 02:22 -0200, Mauro Carvalho Chehab wrote:
> On Sun, 09 Nov 2008 21:58:36 -0500
> Andy Walls <awalls@xxxxxxxxx> wrote:
> 
> > Mauro,
> > 
> > Adding to my previous pull request.
> > 
> > Please pull from:
> > 
> > http://linuxtv.org/hg/~awalls/cx18-bugfix
> > 
> > for the following:
> > 
> > 8. cx18: Fix unitialized variable problem upon APU firmware file read failure
> > 7. cx18: Prevent CX23418 from clearing it's outgoing ack interrupts to driver
> > 6. cx18: Minor fixes to APU firmware load process
> > 5. cx18: Further changes to improve mailbox protocol integrity & performnce
> > 4. cx18: Improve handling of outgoing mailboxes detected to be busy
> > 3. cx18: Roll driver version number due to significant changes
> > 2. cx18: Add outgoing mailbox mutexes and check for ack via waitq vs poll
> > 1. cx18: Use default kernel work queue; fix streaming flag for work handler
> > 
> > Aside from patches that may build upon each other, there is a critical
> > dependency between #2 and #7 above.  #2 converts the driver to use a
> > wait queue instead of polling to check for command acknowledgments.  #7
> > ensures that the processing unit in the CX23418, that sends the
> > interrupt to acknowledge the command, doesn't clear the interrupt status
> > flag on it's own.  Without change #7, change #2 will break the cx18
> > driver for likely many users.
> 

> Please keep in mind that you should avoid submitting high priority big patches
> after the merge window, since:
> 
> 	- ideally, bug fixes are patches that are simple enough to not break other things;
> 	- big patches tend to conflict with "normal" patches that will wait for the next merge window.
> 
> So, please double check the applied patches at my linux-2.6.git tree, and see
> if they will work with cx18 devices.

Mauro,

I'm sorry for taking so long to get back to you (unplanned personal
matters that needed my immediate attention).

I have inspected the HEAD of the git tree:

git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git


What you have merged looks OK so far, except for this one liner change
below, that didn't get merged, needs to be applied as well or users will
really gripe.

I'll let you know when my inspection and test is complete sometime today
and if I find anything more.

Regards,
Andy


changeset:   9502:a51b29789fb4
user:        Andy Walls <awalls@xxxxxxxxx>
date:        Sat Nov 01 00:07:36 2008 -0400
files:       linux/drivers/media/video/cx18/cx18-mailbox.c
description:
cx18: Mark CX18_CPU_DE_RELEASE_MDL as a slow API call

From: Andy Walls <awalls@xxxxxxxxx>

cx18: Mark CX18_CPU_DE_RELEASE_MDL as a slow API call.
Give the encoder time to complete the MDL release before destroying the
encoder internal task.  This avoids an encoder lockup on the next digital
capture and error messages about buffers being returned for an inactive
encoder task handle.

Priority: high

Signed-off-by: Andy Walls <awalls@xxxxxxxxx>


diff -r 422923ee92af -r a51b29789fb4 linux/drivers/media/video/cx18/cx18-mailbox.c
--- a/linux/drivers/media/video/cx18/cx18-mailbox.c     Fri Oct 31 19:49:12 2008 -0400
+++ b/linux/drivers/media/video/cx18/cx18-mailbox.c     Sat Nov 01 00:07:36 2008 -0400
@@ -83,7 +83,7 @@ static const struct cx18_api_info api_in
        API_ENTRY(CPU, CX18_CPU_DE_SET_MDL_ACK,                 0),
        API_ENTRY(CPU, CX18_CPU_DE_SET_MDL,                     API_FAST),
        API_ENTRY(CPU, CX18_APU_RESETAI,                        API_FAST),
-       API_ENTRY(CPU, CX18_CPU_DE_RELEASE_MDL,                 0),
+       API_ENTRY(CPU, CX18_CPU_DE_RELEASE_MDL,                 API_SLOW),
        API_ENTRY(0, 0,                                         0),
 };
 




_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer