Re: [PULL] http://linuxtv.org/hg/~awalls/cx18-bugfix

[Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>]

On Sun, 09 Nov 2008 21:58:36 -0500
Andy Walls <awalls@xxxxxxxxx> wrote:

> Mauro,
> 
> Adding to my previous pull request.
> 
> Please pull from:
> 
> http://linuxtv.org/hg/~awalls/cx18-bugfix
> 
> for the following:
> 
> 8. cx18: Fix unitialized variable problem upon APU firmware file read failure
> 7. cx18: Prevent CX23418 from clearing it's outgoing ack interrupts to driver
> 6. cx18: Minor fixes to APU firmware load process
> 5. cx18: Further changes to improve mailbox protocol integrity & performnce
> 4. cx18: Improve handling of outgoing mailboxes detected to be busy
> 3. cx18: Roll driver version number due to significant changes
> 2. cx18: Add outgoing mailbox mutexes and check for ack via waitq vs poll
> 1. cx18: Use default kernel work queue; fix streaming flag for work handler
> 
> Aside from patches that may build upon each other, there is a critical
> dependency between #2 and #7 above.  #2 converts the driver to use a
> wait queue instead of polling to check for command acknowledgments.  #7
> ensures that the processing unit in the CX23418, that sends the
> interrupt to acknowledge the command, doesn't clear the interrupt status
> flag on it's own.  Without change #7, change #2 will break the cx18
> driver for likely many users.

Applied, thanks.

Please notice that I had to re-prioritize several cx18 patches when merging
upstream on some previous pull requests. 

This happens because bug fix patches you've submitted were dependent on non-bug
fix patches. There were even some cases were a patch is dependent on both fixes
and non-fixes trees! Those patches are really hard to handle on a proper way.

Please keep in mind that you should avoid submitting high priority big patches
after the merge window, since:

	- ideally, bug fixes are patches that are simple enough to not break other things;
	- big patches tend to conflict with "normal" patches that will wait for the next merge window.

So, please double check the applied patches at my linux-2.6.git tree, and see
if they will work with cx18 devices.

I didn't try yet to merge your new series on my -git tree, so I'm not sure what
will apply well.

Cheers,
Mauro

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer