Google
  Web www.spinics.net

Re: [PULL] http://linuxtv.org/hg/~pinchartl/uvcvideo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sat, 8 Nov 2008 23:56:53 +0100
Laurent Pinchart <laurent.pinchart@xxxxxxxxx> wrote:

> Mauro,
> 
> Please pull from http://linuxtv.org/hg/~pinchartl/uvcvideo
> 
> for the following 4 changesets:
> 
> uvcvideo: Add support for Samsung Q310 integrated webcam
> uvcvideo: Add support for Lenovo Thinkpad SL500 integrated webcam
> uvcvideo: Sort the frame descriptors during parsing
> uvcvideo: Handle failed video GET_{MIN|MAX|DEF} requests more gracefully
> 
> Thanks,
> 
> Laurent Pinchart
> 
>  uvc_driver.c |  169 +++++++++++++----------------------------------------------
>  uvc_v4l2.c   |    4 -
>  uvc_video.c  |   63 ++++++++++++++++++---
>  uvcvideo.h   |   14 ++++
>  4 files changed, 106 insertions(+), 144 deletions(-)


Applied, thanks.

Next time, please check your patches with checkpatch (make checkpatch does the
trick):

/tmp/newpatches/hg_uvcvideo_4.patch:
uvcvideo: Handle failed video GET_{MIN|MAX|DEF} requests more gracefully
ERROR: do not use assignment in if condition
#177: FILE: linux/drivers/media/video/uvc/uvc_v4l2.c:255:
+       if ((ret = uvc_commit_video(video, &probe)) < 0)

ERROR: do not use assignment in if condition
#186: FILE: linux/drivers/media/video/uvc/uvc_v4l2.c:319:
+       if ((ret = uvc_commit_video(video, &probe)) < 0)

total: 2 errors, 0 warnings, 314 lines checked




Cheers,
Mauro

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool