[PULL] http://linuxtv.org/hg/~awalls/cx18-bugfix

[Andy Walls <awalls@xxxxxxxxx>]

Mauro,

Adding to my previous pull request.

Please pull from:

http://linuxtv.org/hg/~awalls/cx18-bugfix

for the following:

8. cx18: Fix unitialized variable problem upon APU firmware file read failure
7. cx18: Prevent CX23418 from clearing it's outgoing ack interrupts to driver
6. cx18: Minor fixes to APU firmware load process
5. cx18: Further changes to improve mailbox protocol integrity & performnce
4. cx18: Improve handling of outgoing mailboxes detected to be busy
3. cx18: Roll driver version number due to significant changes
2. cx18: Add outgoing mailbox mutexes and check for ack via waitq vs poll
1. cx18: Use default kernel work queue; fix streaming flag for work handler

Aside from patches that may build upon each other, there is a critical
dependency between #2 and #7 above.  #2 converts the driver to use a
wait queue instead of polling to check for command acknowledgments.  #7
ensures that the processing unit in the CX23418, that sends the
interrupt to acknowledge the command, doesn't clear the interrupt status
flag on it's own.  Without change #7, change #2 will break the cx18
driver for likely many users.

diffstat

 cx18-driver.c   |   16 +---
 cx18-driver.h   |   16 ++--
 cx18-dvb.c      |   37 +++++----
 cx18-firmware.c |   37 +++++++--
 cx18-io.c       |   11 ++
 cx18-io.h       |    1 
 cx18-irq.c      |   32 ++------
 cx18-irq.h      |    1 
 cx18-mailbox.c  |  219 ++++++++++++++++++++++++++++----------------------------
 cx18-mailbox.h  |    7 +
 cx18-streams.c  |    6 -
 cx18-version.h  |    2 
 12 files changed, 210 insertions(+), 175 deletions(-)

Regards,
Andy


On Fri, 2008-11-07 at 17:58 -0500, Andy Walls wrote:
> Mauro,
> 
> Please pull from:
> 
> http://linuxtv.org/hg/~awalls/cx18-bugfix
> 
> for the following:
> 
>  cx18: Roll driver version number due to significant changes
>  cx18: Add outgoing mailbox mutexes and check for ack via waitq vs poll
>  cx18: Use default kernel work queue; fix streaming flag for work handler
> 
> 
> For the last two in that list above, Hans posted his "reviewed-by" in a
> mailing on the ivtv-devel list on Thu, 6 Nov 2008 17:54:42 +0100 (11:54
> EST):
> 
> > Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> 
> 
> diffstat:
> 
>  cx18-driver.c  |   14 +-------
>  cx18-driver.h  |    9 ++---
>  cx18-dvb.c     |   37 +++++++++++++----------
>  cx18-irq.c     |   29 +++++-------------
>  cx18-mailbox.c |   90 +++++++++++++++++++++++++++------------------------------
>  cx18-mailbox.h |    7 +++-
>  cx18-streams.c |    6 +--
>  cx18-version.h |    2 -
>  8 files changed, 90 insertions(+), 104 deletions(-)
> 
> 
> Regards,
> Andy


_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer