Re: S921

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Oct 2008, Steven Toth wrote:

> http://linuxtv.org/hg/v4l-dvb/rev/c5c03a34630c
>
> A few questions come to mind:
>
> 1. As it's ISDB-T, why doesn't it support the S2API?

This seems to be a good improvement for future versions of the driver.

> 2. Why wasn't this posted to the maintainers list for review, prior to merge?

It was posted at LKML.

> 3. The GPL license appears to be missing. Any specific reason?

$ grep GPL v4l/s921*c
v4l/s921_module.c:EXPORT_SYMBOL_GPL(s921_attach);
v4l/s921_module.c:MODULE_LICENSE("GPL");

The module is licensed as GPL.

> 4. Given that it has large #if 0 sections, minor coding style violations, and 
> references to 'extra interfaces' to be reflected 'lateron', shouldn't this of 
> been cleaned up and presented for peer review?

#if 0 are automatically removed.

For sure the driver requires codingstyle fixes, as well as other new 
drivers also need. Patches are welcome.

Cheers,
Mauro

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

  Powered by Linux