Re: [hg:v4l-dvb] Get rid of inode parameter at v4l_compat_translate_ioctl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 21 October 2008, Patch from Mauro Carvalho Chehab wrote:
> The patch number 9330 was added via Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx> to http://linuxtv.org/hg/v4l-dvb master development
> tree.
>
> Kernel patches in this development tree may be modified to be backward
> compatible with older kernels. Compatibility modifications will be
> removed before inclusion into the mainstream Kernel
>
> If anyone has any objections, please let us know by sending a message to:
> 	v4l-dvb-maintainer@xxxxxxxxxxx
>
> ------
>
> From: Mauro Carvalho Chehab  <mchehab@xxxxxxxxxx>
> Get rid of inode parameter at v4l_compat_translate_ioctl()
>
>
> The inode parameter at v4l_compat_translate_ioctl() were just passed over
> several places just to keep compatible with fops.ioctl. However, it weren't
> used anywere.
>
> This patch gets hid of this unused parameter.
>
> Priority: normal
>
> CC: Laurent Pinchart <laurent.pinchart@xxxxxxxxx>
> CC: Mike Isely <isely@xxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
>
> ---
>
>  linux/drivers/media/common/saa7146_video.c       |   12
>  linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c |   11
>  linux/drivers/media/video/uvc/uvc_v4l2.c         |   12
>  linux/drivers/media/video/v4l1-compat.c          |  223 ++++++---------
>  linux/drivers/media/video/v4l2-ioctl.c           |    6
>  linux/include/media/v4l2-ioctl.h                 |    6
>  6 files changed, 131 insertions(+), 139 deletions(-)
>
> <diff discarded since it is too big>
>
> ---
>
> Patch is available at:
> http://linuxtv.org/hg/v4l-dvb/rev/33731b680f256723fccc3598f4eefbfad04b0b0e

As the uvcvideo driver doesn't support V4L1 anyway, it would be easier to 
remove the call to v4l_compat_translate_ioctl() completely. Can you modify 
your patch or should I submit a patch on top of it ? If modifying your patch 
is not possible, can you then merge both when pushing to Linus ?

Best regards,

Laurent Pinchart

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

  Powered by Linux