Google
  Web www.spinics.net

Re: [PULL] http://linuxtv.org/hg/~mkrufky/hardy-lum-compat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Mauro Carvalho Chehab wrote:
> On Fri, 17 Oct 2008 10:41:48 -0300
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote:
>
>   
>> I think that the following patch will do a better job. It will create a rule to
>> remove all obsolete modules from the ubuntu messy backport directory.
>>
>> Please test. I'll still do some work there to avoid importunate users for other
>> distros where you don't have such buggy install.
>>     
>
> Ok, this is version 2 of the patch.
>   

Please see my comments below.

> ---
> Avoid troubles with testing V4L/DVB with some Ubuntu distros
>
> Ubuntu has a non-standard place to insert newer drivers. Since this is not
> expected by the installing scripts, it causes several errors when you do make
> install.
>
> This patch tries to avoid those issues by removing the obsolete modules under
> ubuntu/media/*.
>
> It should be noticed that this script will keep any out-of-tree driver that
> aren't merged untouched, even if those will be broken by make install.
>
> Due to that, a warning message will be displayed, if the makefile detects the
> Ubuntu messy backport directory.
>
> While being there, I've also removed a bogus echo msg.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
>
> diff -r 14f150dc3de6 v4l/scripts/make_makefile.pl
> --- a/v4l/scripts/make_makefile.pl	Fri Oct 17 09:26:39 2008 -0300
> +++ b/v4l/scripts/make_makefile.pl	Fri Oct 17 11:02:04 2008 -0300
> @@ -157,6 +157,33 @@
>  	}
>  }
>  
> +#
> +# Special hack for Ubuntu with their backport mess
> +#
> +sub removeubuntu()
> +{
> +	my $dest = "/lib/modules/\$(KERNELRELEASE)/ubuntu/media";
> +	my $filelist;
> +
> +	while ( my ($dir, $files) = each(%instdir) ) {
> +		$filelist .= join(' ', keys %$files);
> +	}
> +	while ( my ($dir, $files) = each(%obsolete) ) {
> +		$filelist .= join(' ', keys %$files);
> +	}
> +	$filelist =~ s/\s+$//;
> +	
> +	print OUT "\t\@if [ -d $dest ]; then ";
> +	print OUT "echo -e \"\\nHmm... distro kernel with a non-standard place for module backports detected.\\n";
> +	print OUT "Please always prefer to use vanilla upstream kernel with V4L/DVB\\n";
> +	print OUT "I'll try to remove old/obsolete LUM files from $dest:\"; ";
> +	print OUT "files='", $filelist, "'; ";
> +
> +	print OUT "for i in \$\$files;do if [ -e $dest/*/\$\$i ]; then ";
> +	print OUT "echo -n \"\$\$i \";";
> +	print OUT " rm $dest/*/\$\$i; fi; done;";
> +	print OUT " fi\n";
> +}
>  
>  getobsolete();
>  
> @@ -169,6 +196,7 @@
>  print OUT "\t\@strip --strip-debug \$(inst-m)\n\n";
>  
>  removeobsolete();
> +removeubuntu();
>  
>  print OUT "\t\@echo \"Installing kernel modules under \$(DESTDIR)\$(KDIR26)/:\"\n";
>  
> @@ -191,8 +219,8 @@
>  print OUT "media-rminstall::\n";
>  
>  removeobsolete();
> +removeubuntu();
>  
> -print OUT "\t\@echo -e \"\\nRemoving old \$(DEST) files\\n\"\n";
>  while ( my ($dir, $files) = each(%instdir) ) {
>  	print OUT "\t\@echo -e \"\\nRemoving old \$(KDIR26)/$dir files:\"\n";
>  	print OUT "\t\@files='", join(' ', keys %$files), "'; ";
>   


Mauro,

This does not work...

The output was:

Hmm... distro kernel with a non-standard place for module backports 
detected.
Please always prefer to use vanilla upstream kernel with V4L/DVB
I'll try to remove old/obsolete LUM files from 
/lib/modules/2.6.24-21-generic/ubuntu/media:
xc5000.ko ov511.ko saa7134-alsa.ko au8522.ko cx88-alsa.ko Installing 
kernel modules under /lib/modules/2.6.24-21-generic/kernel/drivers/media/:


It did not remove au0828.ko , sms1xxx.ko, nor uvcvideo.ko

Also, I wish you didn't have to trash the Ubuntu kernel folks in the 
changeset, calling their method a mess.  Just because GregKH trashed 
them at the Plumbers conference does not mean that everybody else should 
as well.

I find this derogatory and offensive.  Just because you don't like how 
they handled their own backports does not mean that it is a mess -- The 
beauty of Linux is that one may do as they please within their own 
distribution.  This is no place to voice your opinion of other distro 
methods.


I'm not sure what went wrong with your patch -- it LOOKS ok, but it did 
not work :-/

Can you please just merge my tree for now, and then undo my changes once 
you have a better method?

Regards,

Mike

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool