Re: [PULL] http://linuxtv.org/hg/~stoth/mfe | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
Mauro Carvalho Chehab wrote:
> On Wed, 15 Oct 2008 14:41:27 -0400
> Steven Toth <stoth@xxxxxxxxxxx> wrote:
>
>> Mauro,
>>
>> Please pull from http://www.linuxtv.org/hg/~stoth/mfe
>
> Applied, thanks.
>
> However, I can see to issues on this series: memory leaks and improper
> unregistration code.
>
>> - S2API: Add Multiple-frontend on a single adapter support.
>
> This one has some memory leaks. For example:
>
> if ( (NULL == fe0->dvb.frontend) || (fe1 && NULL == fe1->dvb.frontend) ) {
> printk(KERN_ERR
> "%s/2: frontend initialization failed\n",
> core->name);
> return -EINVAL;
>
> one of the frontends might be allocated/attached. Also, just returning here
> won't call some functions for un-registering things at dvb core.
>
> Also, on error at _init, or at _remove, fe2 will be kept initialized.
>
>> - cx23885: Move the MFE frontend allocation into the correct place
>
> I suspect that the same issue is also present here.
>
> due to some OOPS we had in the past, when frontend register fails, I suspect
> that the dvb unregister functions will OOPS on multi-frontend boards, due to
> the lack of the proper frontend unregister code for the second frontend.
For some reason I missed this email during my first pass this morning.
I'll look into this as part of the cleanups.
- Steve
_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
|
|
-->
