Re: [PULL] http://linuxtv.org/hg/~stoth/s2 | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Sat, 11 Oct 2008 19:53:52 -0400
Steven Toth <stoth@xxxxxxxxxxx> wrote:
> Mauro,
>
> This is the first in a large set of patches I'll be send to you over the
> next few days.
Ok. Be careful to do all changes at the API itself during the merge window.
>
> These are basic cleanups for the S2API, based on feedback and testing
> I've had from Kaffeine, VDR and myth users.
> - S2API: Stop an OOPS if illegal commands are dumped in S2API.
+ printk("%s: tvp.cmd = 0x%08x (undefined/unknown/invalid)\n",
Please use a kernel message level at the printk.
> - S2API: Bugfix related to DVB-S / DVB-S2 tuning for the legacy API.
> - S2API: Remove the hardcoded command limit during validation
> - Allow custom inittab for ST STV0288 demodulator.
> - Remove NULL pointer in stb6000 driver.
> - Add support for DvbWorld USB cards with STV0288 demodulator.
> - S2API: Change _8PSK / _16APSK to PSK_8 and APSK_16
> - cx24116: Add module parameter to return SNR as ESNO.
> - S2API: frontend.h cleanup
Instead of this:
<commit_msg>
From: Brandon Philips <bphilips@xxxxxxx>
>From the author:
"Reviewing the code briefly and saw this.
You can't change more than DTV_IOCTL_MAX_MSGS at once, not 16."
Priority: normal
Signed-off-by: Steven Toth <stoth@xxxxxxxxxxx>
Signed-off-by: Brandon Philips <bphilips@xxxxxxx>
</commit_msg>
You should just do:
<commit_msg>
From: Brandon Philips <bphilips@xxxxxxx>
Reviewing the code briefly and saw this.
You can't change more than DTV_IOCTL_MAX_MSGS at once, not 16.
Priority: normal
Signed-off-by: Brandon Philips <bphilips@xxxxxxx>
Signed-off-by: Steven Toth <stoth@xxxxxxxxxxx>
</commit_msg>
The same issue is also found on other places over your patch series.
> - update CARDLIST.cx88
Cardlist is updated when you do "make cardlist". Any manual edition there will
be lost or overrided when a newer card is added.
Also, why are you adding this board to cardlist without actually adding the
board?
Cheers,
Mauro
_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
|
|
-->
