Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-radios | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Thu, Oct 9, 2008 at 7:30 AM, Douglas Schilling Landgraf
<dougsland@xxxxxxxxx> wrote:
> Hello Mauro,
>
> Please pull from http://linuxtv.org/hg/~dougsland/v4l-radios
> for the following:
>
> radio-zoltrix: Add checking for frequency
> dsbr100: Add returns and fix codingstyle for vidioc_s_ctrl
>
- if (freq == 0)
- return 1;
+ if (freq == 0) {
+ printk(KERN_WARNING "zoltrix: received zero freq. Failed to set.\n");
+ return -1;
+ }
+
why not directly use -EINVAL?
I've seen alot patches replacing -1 with something from errno.h
Markus
> Cheers,
> Douglas
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@xxxxxxxxxxx
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
>
_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
|
|
-->
