Google
  Web www.spinics.net

Re: [PATCH] Bug introduced during xc5000 callback refactoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hey Mauro,

This is a kernel panic that's I submitted a fix for a week ago.  I've
had three users complain to me last week via email about this.  It's a
blindingly obvious case where somebody accidentally pasted some
required code after the return statement.

Could you please merge this?

Devin

On Fri, Oct 3, 2008 at 5:09 PM, Michael Krufky <mkrufky@xxxxxxxxxxx> wrote:
> Michael Krufky wrote:
>>
>> Devin Heitmueller wrote:
>>
>>>
>>> Tested the merged version of the Pinnacle 801e support, and it looks
>>> like a regression got introduced during the refactoring of the xc5000
>>> tuner callback.
>>>
>>> Attached is a patch that fixes the panic condition.  I also put an
>>> extra check to validate the command sent to the callback.  Let me know
>>> if doing this in the same patch is a problem, and I can break it into
>>> two different patches.
>>>
>>> Regards,
>>>
>>> Devin
>>>
>>>
>>
>> Thanks for testing and the fix, Devin.
>>
>> Reviewed-by: Michael Krufky <mkrufky@xxxxxxxxxxx>
>>
>> Please merge this, Mauro.
>>
>> Regards,
>>
>> Mike
>>
>
> Mauro,
>
> Are you going to merge this??  I would push it up myself, but you have been
> merging emailed patches before pulling hg trees for merge.  If I merge this
> to my own tree and request a merge, I might be wasting my time if you merge
> it yourself before receiving my pull request.
>
> Can you please respond?
>
> Thanks,
>
> Mike
>



-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer

[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool