Re: [PATCH] Add support for MSI TV@nywhere Plus remote

[hermann pitton <hermann-pitton@xxxxxxxx>]

Hi,

Am Montag, den 15.09.2008, 01:26 -0300 schrieb Mauro Carvalho Chehab:
> On Sun, 14 Sep 2008 04:35:19 +0200
> hermann pitton <hermann-pitton@xxxxxxxx> wrote:
> 
> > Mauro,
> > 
> > this is the oldest and most important outstanding patch we have.
> > 
> > There are whole generations of cards still without of any IR support,
> > since years, because of that.
> > 
> > If this one should still hang on coding style violations, please let me
> > know.
> 
> I'll handle this patch soon. I'm currently away (in Portland, due to Plumbers
> and KS conferences), so, maybe I'll wait until the next week for committing it.

fine. My small other stuff will cause no merge conflicts.

> > If you would ever find time again, have a look at my patch enabling
> > first support for the new Asus Tiger 3in1, which I have only as an OEM
> > board, but which is coming up to global distribution now and likely will
> > cover all newer boards.
> 
> Could you please forward it me again any pending patches? Better if you can do
> it at the beginning of the next week. If I don't answer about a patch in about
> one week, the better is to ping me about it.
> 
> > I wasted some time again, to fit into the 80 columns rule on
> > saaa7134-dvb.c, and all I can say is, this way not with me.
> 
> The 80 cols rule is just a warning. On some cases, it helps to improve
> readability. Also, it is generally easier to review codes that fit on 80 cols,
> since it helps me to open a window comparing a file and a patched version with
> some tool like kdiff3, where the several file revisions are presented side by side.
> 
> > Please exercise it yourself now, you have all relevant information, show
> > the resulting code and explain, why such crap should be looking good.
> 
> I did my self some coding style patches and the end result was an easier to
> read code. As already discussed, such warnings/errors should be used as a hint
> of troubles, not as absolute rules.
> 

I cooled down next day and a patch within 80 columns is on the lists :)

Please pick up this one first and report any issues.

I'll provide the other few patches then next weekend.

Good times in Portland, peace and cooperation.

Cheers,
Hermann



_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer