Re: [pull] http://linuxtv.org/hg/~stoth/v4l-dvb

[Michael Krufky <mkrufky@xxxxxxxxxxx>]

Steven Toth wrote:
> Mauro Carvalho Chehab wrote:
>> Hi Steve,
>>
>> On Thu, 24 Jul 2008 19:10:32 -0400
>> Steven Toth <stoth@xxxxxxxxxxx> wrote:
>>
>>> Mauro,
>>>
>>> Quite a few memory and dual channel related fixes for the cx23885
>>> tree. Some good improvements for the HVR1800 and some DViCO boards.
>>>
>>> Please pull from http://www.linuxtv.org/hg/~stoth/v4l-dvb
>>
>> Committed, thanks.
>>
>> I noticed some blank SOB's on your patches. Probably, it is an error
>> on your
>> environment setup. Maybe you didn't set what is described at
>> README.patches:
>
> It's set, it's always been set. The scripts added two SOB's and I
> don't know why. I figured the scripts broke. I'm using the same stable
> environment that's I've been using for the last 18 months.
>
>
>>
>> d) For "make commit" to work properly, the HGUSER shell environment var
>>    should be defined (replacing the names at the left):
>>
>>         HGUSER="My Name <myemail@xxxxxxxxxx>"
>>
>>    If HGUSER is not set, then, if present, the username defined in the
>>    user's ~/.hgrc file will be used.  Use of the .hgrc file is preferred
>>    over the HGUSER variable according to the hg man page.
>
> I've never had a .hgrc file.
>
>>
>> Please fix for next pull requests, since this generates mail bounces
>> at the hg
>> mailbomb script.
>
> mkrufky, have you seen this before?

This was a bug in the "make commit" scripts from approx 3 weeks ago,
which Mauro has since fixed.

This changeset shows my bug report to Mauro, and his fix:

http://linuxtv.org/hg/v4l-dvb/rev/4260d7ff0099

Steve committed those changes when the issue was not yet fixed, then he
"hg export"ed those changesets and "hg import"ed them into a new tree
based on current master.

This is now a non-issue.  Any new commits will not have this problem.

Regards,

Mike

_______________________________________________
v4l-dvb-maintainer mailing list
v4l-dvb-maintainer@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer