Re: [PATCH 1/2] v4l2: hardware frequency seek ioctl interface | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Mon, 26 May 2008 20:40:46 +0200 Tobias Lorenz <tobias.lorenz@xxxxxxx> wrote: > Hi Mauro, > > > The patch itself looks good. However, there are several codingstyle errors. Please run checkpatch.pl against it and send me again, having the pointed issues fixed. > > Yes, I know. The errors are a result from trying to follow the coding style of these files. > > This is the file list with comments on coding style and patch: > drivers/media/video/videodev.c: has unusual coding style, but hwseek patch is now corrected > drivers/media/video/compat_ioctl32.c: had already nice coding style, hwseek patch too > include/linux/videodev2.h: has unusual coding style, but hwseek patch is now corrected except from one long line... > include/media/v4l2-dev.h: has unusual coding style, but hwseek patch is now corrected As a general rule, newer patches should follow the current CodingStyle. Yes, I'm aware that there are several drivers not compliant with current CodingStyle rules. > Maybe I should send a coding style cleanup patch for these files too :-) Yes, you can, but globally fixing CodingStyle is somewhat evil ;) This will break any patch that somebody else is working with for that file. Also, any patch applied during your development will break your patch. So, I generally prefer not having such patches (or having it only at the last week before the next open windows). > > The corrected patch is still against linux-2.6.25. I hope it applies cleanly to the mercurial v4l repository. > Applied fine, thanks. Cheers, Mauro _______________________________________________ v4l-dvb-maintainer mailing list v4l-dvb-maintainer@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
|
|
-->
