Re: [linuxtv-commits] [hg:v4l-dvb] Simplifies Kconfig rules.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Tue, 6 May 2008 10:43:12 -0400 "Michael Krufky" <mkrufky@xxxxxxxxx> wrote: > Mauro, > > I disagree with this change. All of the tuners in this list depend on > I2C, but not all tuners do, in general. Likewise, you are moving the > "depends on I2C" to MEDIA_TUNER , but these tuner modules do not > depend on MEDIA_TUNER. > > I think this patch should be reverted. I think you had a nice idea to > make the Kconfig menus simpler, but I don't think we gain anything > from this change at all. In fact, this causes additional errors for > if we select these tuner modules and do not select MEDIA_TUNER, in > cases where we want DVB support without video4linux. It seems that you didn't got what's happening at common/tuners/Kconfig: > > config MEDIA_TUNER > > tristate > > - default DVB_CORE || VIDEO_DEV > > - depends on DVB_CORE || VIDEO_DEV > > + default VIDEO_MEDIA && I2C > > + depends on VIDEO_MEDIA && I2C > > select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE > > select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE > > select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE With or without the patch, if DVB_CORE and/or VIDEO_DEV is 'Y' or 'M', this symbol is 'Y' or 'M'. So, DVB won't break without V4L. So, if you have only DVB_CORE = 'M', MEDIA_TUNER = 'M'. This patch (together with another patch) is needed to fix a bug reported by Alistair, at LKML. In fact, this will fix some issues that happens if DVB_CORE is 'Y' and VIDEO_DEV is 'M' (or the reverse), since, on those cases, all tuner drivers should be 'Y'. Also, it should be noticed that _all_ tuners that can be shared between DVB and V4L need to support I2C, since this is a requirement for tuner-core to work. What this patch does is to replace DVB_CORE || VIDEO_DEV to VIDEO_MEDIA, and to replace: (DVB_CORE || VIDEO_DEV) && I2C (that is common to all tuners under common/tuners) to: MEDIA_TUNER. What happens is that our Kconfig stuff is so complex that even small changes are breaking the Kbuild. We really need to make things simpler, otherwise we will keep breaking it on every new kernel. Cheers, Mauro _______________________________________________ v4l-dvb-maintainer mailing list v4l-dvb-maintainer@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer