[PULL] http://linuxtv.org/hg/~mkrufky/m920x | |
| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] | |
On Thu, 29 Mar 2007 21:40:45 -0400
Michael Krufky <mkrufky@xxxxxxxxxxx> wrote:
> Aapo Tahkola wrote:
> > On Thu, 29 Mar 2007 09:11:41 -0400
> > Michael Krufky <mkrufky@xxxxxxxxxxx> wrote:
> >
> >> Mauro Carvalho Chehab wrote:
> >>> Hi Michael,
> >>>
> >>> Em Seg, 2007-03-26 ?s 16:56 -0400, Michael Krufky escreveu:
> >>>> Mauro,
> >>>>
> >>>> Please pull from:
> >>>>
> >>>> http://linuxtv.org/hg/~mkrufky/m920x
> >>>>
> >>>> for the following:
> >>>>
> >>>> - m920x: Add support for LifeView TV Walker Twin
> >>>> - m920x: add "c-basic-offset: 8" to help emacs to enforce tabbing
> >>>> style
> >>>> - m920x: Initial support for devices likely manufactured by Dposh
> >>>> - m920x: various whitespace cleanups
> >>>> - m920x: group like functions together
> >>>> - m920x: remove duplicated code
> >>>> - m920x: replace deb_rc with deb
> >>>> - m920x: rename function prefixes from m9206_foo to m920x_foo
> >>> I noticed that several of those patches were not signed for Aapo.
> >>> Since he is the author of m920x, he should ack the changes on his
> >>> work or otherwise sign all patches.
> >>>
> >>> Aapo,
> >>> Could you please check those patches?
> >>>
> >>> Cheers,
> >>> Mauro
> >>>
> >>
> >> Aapo's s-o-b is on all of the functionality changing patches. The
> >> simple cleanup patches are the ones that lack his s-o-b:
> >>
> >> - m920x: add "c-basic-offset: 8" to help emacs to enforce tabbing
> >> style
> >> - m920x: various whitespace cleanups
> >
> > I'm against both these changes as they make code look inconsistent
> > and bad. Some of the multi line statements are also incorrectly
> > padded with spaces:
> > + if ((ret = m9206_write(d->udev, M9206_I2C,
> > + (msg[i].addr << 1) |
> > + (msg[i].flags & I2C_M_RD ? 0x01 : 0),
> > + 0x80)) != 0)
> >
> > This should be written as:
> > + if ((ret = m9206_write(d->udev, M9206_I2C,
> > + (msg[i].addr << 1) |
> > + (msg[i].flags & I2C_M_RD ? 0x01 :
> > 0),
> > + 0x80)) != 0)
> >
> > + if (msg[i].flags & (I2C_M_NO_RD_ACK | I2C_M_IGNORE_NAK |
> > + I2C_M_TEN) || msg[i].len == 0) {
> >
> > I2C_M_TEN on wrong line.
> >
> > + int stop = (i+1 == num && j+1 == msg[i].len)
> > + ? 0x40 : 0x01;
> >
> > + if ((adap->fe = dvb_attach(mt352_attach,
> > &megasky_mt352_config,
> > + &adap->dev->i2c_adap)) == NULL)
> >
> > + if ((adap->fe = dvb_attach(tda10046_attach,
> > + &tvwalkertwin_0_tda10046_config,
> > + &adap->dev->i2c_adap)) == NULL)
> >
> > tvwalkertwin_0_tda10046_config should be on the first line for
> > consistency.
> >
> > I have no editor capable enough to deal with this properly so I'd
> > rather not pad to 80-col at all.
> >
> > And yes, I'm as passionate about coding style as you are about
> > typos. :)
> >
> >> - m920x: group like functions together
> >
> > I like this one.
> > Signed-of-by: Aapo Tahkola <aet@xxxxxxxxxxxxxx>
> >
> >> - m920x: remove duplicated code
> >
> > Signed-of-by: Aapo Tahkola <aet@xxxxxxxxxxxxxx>
> >
> >> These patches do not require Aapo's sign-off, and I have already
> >> explained in my prior email the reason why the "group like
> >> functions together" patch is large. There is no functional
> >> changes in those patches. Meanwhile, these patches do not touch
> >> Aapo's code -- they touch Nick Andrew's code.
> >>
> >> I am maintaining these dvb-usb drivers. These changesets contain
> >> my sign-off, and I am a dvb maintainer. Of course, additional
> >> review never hurts, but it is not required in this instance.
> >>
> >> Those developers sent their patches to ME so that I can review them
> >> and apply them as I see fit. Again, this code falls under my
> >> maintenance. You should pull these changes into master now.
> >>
> >> Aapo, when you see this email, please respond with your ACK, so
> >> that Mauro doesn't continue to hold up the development process.
> >
> > Well, I'd appreciate if I could just have my own repository. I'm
> > quite bothered by the bureaucracy and s-o-b-spamming I have to do
> > already.
> >
> > I would also like to force users to test some experimental code that
> > otherwise will never get tested.
> >
>
> OK, How's about this...
>
> Aapo, please send me your ssh-rsa key, and I'll create an account for
> you. Then, you should clone my m920x tree, and make the changes that
> you mentioned above. When all is ready, then you should request that
> Mauro pull your tree.
Yep, that will do. I'll have a look tomorrow or so.
http://www.rasterburn.org/~aet/linuxtv.pub
Thanks
--
Aapo Tahkola
|
|
-->
