Google
  Web www.spinics.net

patch for zr364xx driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Antoine Jacquet wrote:
> Hello,
> 
>> Anyway, here is the patch:
>> http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=6b208a1d566c;style=gitweb
>>
> 
> Yes, I also saw your patch on linux-usb-devel, but since there was some
> discussion around it I did not include it yet, sorry about this.
> My only concern was that swab16s does not seem to be widely used in the
> kernel (there don't seem to be any drivers using it).
> 
>> Antoine, does it look ok?
> 
> I tested it and it is ok with 2 cameras (one of them is swapping bytes
> so it is a good test case).
> How should we process to include your patch, Mauro will pull it from
> your tree, or should I merge it into my tree?
> 
> Thanks a lot and best regards,
> 
> Antoine
> 

Antoine,

The proper course of action is for you to do either of the following:

a) pull Trent's changeset into your tree, then ask Mauro to pull, cc
v4l-dvb-maintainer.

-or-

b) reply-to-all to Trent's email, making sure that Trent, v4l-dvb-maintainer AND
Mauro are all included as recipients to the email, include your Ack, in the form:

Acked-by: Maintainer Name <email@xxxxxxxx>

followed by a message to Mauro, showing your approval while asking him to pull
Trent's tree into the master branch.

---

Either of the above are acceptable ways to handle the situation, assuming that
you approve of Trent's change.

If, however, you did not agree with his patch, you would respond to his email,
(keeping cc to v4l-dvb-maintainer) with the word NACK in the body of the
email...  Then, you state your reason for the NACK, and give suggestions as to
what can be done to make the changeset acceptable to you (if possible), or
provide an alternate changeset and ask the original changeset author for testing
and/or approval.

Regards,

Michael Krufky



[Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [Linux USB]

-->
Add to Google Powered by Linux

Google PageRank Checking tool