Re: [PULL STABLE] http://linuxtv.org/hg/~hverkuil/v4l-dvb2

[mchehab at infradead.org (Mauro Carvalho Chehab)]

Em Seg, 2007-02-05 ?s 21:16 +0100, Hans Verkuil escreveu:
> On Monday 05 February 2007 21:04, Mike Isely wrote:
> > I will test, but I likely won't have the chance to do that until
> > Tuesday evening (30 hours from now in Chicago).
> 
> Thanks for letting us know. The patch will hold until then :-) The 
> pvrusb2 is different enough that I want to have your Ack first.

Hmm... were this patch also at the same tree you've asked me to pull? If
so, it were already added to master.

Please, next time, please take care not asking me to pull something that
may need other acks at the same tree you've already asked me to pull and
I didn't yet.

As Mike didn't sent me a NAK, there's no need for now to revert the
patch.

Mike,

Please test it as soon as possible and give me some feedback. I'll keep
this patch holded, not including it on my -git. If needed, we can revert
it or, otherwise, add a fix patch.

We should take care to be fast, since merging window for 2.6.21 is open,
and I shouldn't be on my town during next week.

Cheers,
Mauro


> Regards,
> 
> 	Hans
> 
> >
> >   -Mike
> >
> > On Mon, 5 Feb 2007, Hans Verkuil wrote:
> > > Mauro,
> > >
> > > Once Mike Isely has acked this change, can you please pull from
> > > http://linuxtv.org/hg/~hverkuil/v4l-dvb2 for the following:
> > >
> > > - cx25840 request_firmware failed due to wrong device.
> > >
> > > The firmware load of the cx25840 broke in 2.6.20. Changes in 2.6.20
> > > brought this bug to light (it's always been wrong, but no one ever
> > > noticed).
> > >
> > > Mike Krufky: once Mike Isely acked this, can you queue it for
> > > 2.6.20.1? It's a pretty serious bug, next time I really should do a
> > > quick test earlier in the release cycle.
> > >
> > > Mike Isely: can you test this change on a pvrusb2 and Ack it if it
> > > works OK? For your convenience I've added the patch below as well
> > > (just a one liner).
> > >
> > > Thanks,
> > >
> > >         Hans
> > >
> > >
> > > -------------------------------------------
> > >
> > > diff -r 2cb0a67c420a -r d1bfc4440540
> > > linux/drivers/media/video/cx25840/cx25840-firmware.c
> > > --- a/linux/drivers/media/video/cx25840/cx25840-firmware.c      Sun
> > > Feb 04 23:39:25 2007 +0100
> > > +++ b/linux/drivers/media/video/cx25840/cx25840-firmware.c      Mon
> > > Feb 05 20:56:22 2007 +0100
> > > @@ -39,7 +39,7 @@
> > >  #define FWSEND 48
> > >
> > >  #if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,0)
> > > -#define FWDEV(x) &((x)->adapter->dev)
> > > +#define FWDEV(x) &((x)->dev)
> > >  #else
> > >  #define FWDEV(x) (x)->name
> > >  #endif
> 
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@xxxxxxxxxxx
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
-- 
Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>