[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 2/5] tps6586x: Add device tree support
- Subject: Re: [RFC v2 2/5] tps6586x: Add device tree support
- From: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
- Date: Wed, 25 Apr 2012 12:14:29 +0200
- Cc: Terje Bergström <tbergstrom@xxxxxxxxxx>, Stephen Warren <swarren@xxxxxxxxxxxxx>, Joerg Roedel <joerg.roedel@xxxxxxx>, devicetree-discuss@xxxxxxxxxxxxxxxx, Rhyland Klein <rklein@xxxxxxxxxx>, Wolfram Sang <w.sang@xxxxxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Grant Likely <grant.likely@xxxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, Rob Herring <rob.herring@xxxxxxxxxxx>, Ben Dooks <ben-linux@xxxxxxxxx>, Colin Cross <ccross@xxxxxxxxxxx>, linux-tegra@xxxxxxxxxxxxxxx, Jon Mayo <jmayo@xxxxxxxxxx>, Liam Girdwood <lrg@xxxxxx>, Hiroshi Doyu <hdoyu@xxxxxxxxxx>
- Delivered-to: dri-devel@xxxxxxxxxxxxxxxxxxxxx
- In-reply-to: <20120425101031.GH3195@opensource.wolfsonmicro.com>
- References: <email@example.com> <firstname.lastname@example.org> <20120425101031.GH3195@opensource.wolfsonmicro.com>
- User-agent: Mutt/1.5.21 (2010-09-15)
* Mark Brown wrote:
> On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote:
> > This commit adds device tree support for the TPS6586x regulator.
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> This looks basically good from a quick scan through but the pattern of
> looking up regulator nodes by name is very common so should be factored
> out - I made a similar comment in response to a recent patch from
> Rhyland Klein and earlier today he posted a patch "regulator: add
> generic of node parsing for regulators" which does just that. Can you
> please redo this on top of his code? I'll probably apply it later
> today, though I didn't properly read the code yet.
I'll take a look.
> I guess it should be possible to apply this patch independantly of the
> rest of the series? It shouldn't break bisection if it's missing as
> it's a new driver that's being added as the consumer.
Yes, it can be applied independently.
Description: PGP signature
dri-devel mailing list
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Free Online Dating]
[Big List of Linux Books]