Re: [RFC PATCH] drm: Add plane event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:
>
> On 04/18/2012 05:46 PM, Daniel Vetter wrote:
>>
>> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote:
>>>
>>> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is
>>> for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to
>>> provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl
>>> can change the framebuffer of plane but user can't know completion of
>>> changing the framebuffer of plane via event. If DRM_MODE_PLANE_EVENT is
>>> added, we can also do pageflip of a plane.
>>>
>>> Signed-off-by: Joonyoung Shim<jy0922.shim@xxxxxxxxxxx>
>>> Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>
>>
>> If I understand the current kms api correctly, set_plane is akin to
>> set_base and should not generate an asynchronous flip completion event.
>> To
>> do that we need a new pageflip ioctl which changes a complete set of fb +
>> planes + any crtc attributes that might be in an atomic fashion. At which
>> point we can just reuse the existing page flip event mechanism.
>
>
> It seems better way to add new pageflip ioctl for plane. I will try it.

fwiw, an atomic mode set which can update crtc and zero or more plane
layers is, I think, the way to go.  Jesse Barnes had an RFC for this,
although IIRC it was only the API and not the implementation.  And
combination w/ the plane/crtc properties patchset to allow setting
properties as part of the update might not be a bad thing either.

BR,
-R

> Thanks for review.
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [PDAs]     [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86] [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [PDAs]     [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]

Add to Google Powered by Linux