Re: [PATCH 4/8] drm: add generic ioctls to get/set properties on any object

[Eugeni Dodonov <eugeni@xxxxxxxxxxx>]

On Thu, Mar 29, 2012 at 18:27, Paulo Zanoni <przanoni@xxxxxxxxx> wrote:

+       switch (arg_obj->type) {
+       case DRM_MODE_OBJECT_CONNECTOR:
+               ret = drm_mode_connector_set_obj_prop(arg_obj, property,
+                                                     arg->value);
+               break;
+       }

<bikeshedding>

Perhaps we could add a debug message here for catch the unhandled types..

</bikeshedding>

But apart from that,

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@xxxxxxxxx>

-- 
Eugeni Dodonov



_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel